ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

Hotell · 2023-05-25T14:13:18Z

Previous Behavior

New Behavior

command	before	after	delta
yarn buildci	48m 41s	41m 00s	+16%
yarn workspace @fluentui/react-components type-check	45s	7s	+85%

Scoped time comparison

react-text

command	exec time	delta
yarn workspace @fluentui/react-text tsc -b	23.7s	base
yarn workspace @fluentui/react-text type-check	4.6s	-80.6% 🚅

react-components

command	exec time	delta
yarn workspace @fluentui/react-components tsc -b	34.7s	base
yarn workspace @fluentui/react-components type-check	5.4s	-84.4% 🚅

Related Issue(s)

Fixes partially [Feature]: improve type-checking performance #30516

fabricteam · 2023-05-25T14:21:30Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react` ActivityItem	`68.833 kB` `22.613 kB`
`react` Announced	`36.473 kB` `12.628 kB`
`react` Autofill	`15.365 kB` `4.743 kB`
`react` Breadcrumb	`196.083 kB` `58.757 kB`
`react` Button	`190.127 kB` `55.019 kB`
`react` ButtonGrid	`175.918 kB` `53.25 kB`
`react` Calendar	`118.756 kB` `36.101 kB`
`react` Callout	`80.866 kB` `26.564 kB`
`react` Check	`51.062 kB` `17.152 kB`
`react` Checkbox	`57.791 kB` `19.17 kB`
`react` ChoiceGroup	`63.339 kB` `20.824 kB`
`react` ChoiceGroupOption	`56.601 kB` `18.695 kB`
`react` Coachmark	`89.704 kB` `28.407 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` ColorPicker	`129.984 kB` `40.589 kB`
`react` ComboBox	`245.355 kB` `70.51 kB`
`react` CommandBar	`197.362 kB` `58.46 kB`
`react` ContextualMenu	`150.967 kB` `46.982 kB`
`react` DatePicker	`180.318 kB` `54.947 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`225.886 kB` `64.647 kB`
`react` Dialog	`205.294 kB` `61.428 kB`
`react` Divider	`17.63 kB` `6.234 kB`
`react` DocumentCard	`211.08 kB` `62.793 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`33.345 kB` `11.166 kB`
`react` Dropdown	`227.732 kB` `66.867 kB`
`react` ExtendedPicker	`94.987 kB` `27.297 kB`
`react` Fabric	`39.75 kB` `13.688 kB`
`react` Facepile	`205.992 kB` `61.67 kB`
`react` FloatingPicker	`236.233 kB` `67.368 kB`
`react` FocusTrapZone	`15.831 kB` `5.54 kB`
`react` FocusZone	`53.259 kB` `16.869 kB`
`react` Grid	`175.918 kB` `53.25 kB`
`react` GroupedList	`131.636 kB` `39.657 kB`
`react` GroupedListV2	`119.324 kB` `36.822 kB`
`react` HoverCard	`93.735 kB` `29.778 kB`
`react` Icon	`49.74 kB` `16.603 kB`
`react` Icons	`65.829 kB` `24.212 kB`
`react` Image	`44.79 kB` `15.024 kB`
`react` Keytip	`78.588 kB` `25.825 kB`
`react` KeytipData	`13.585 kB` `4.418 kB`
`react` KeytipLayer	`100.422 kB` `31.128 kB`
`react` Keytips	`103.175 kB` `32.07 kB`
`react` Label	`36.347 kB` `12.639 kB`
`react` Layer	`45.683 kB` `15.585 kB`
`react` Link	`37.673 kB` `12.993 kB`
`react` List	`38.136 kB` `12.004 kB`
`react` MarqueeSelection	`72.119 kB` `21.676 kB`
`react` MessageBar	`184.707 kB` `55.523 kB`
`react` Modal	`90.409 kB` `29.213 kB`
`react` Nav	`183.442 kB` `55.093 kB`
`react` OverflowSet	`31.044 kB` `10.593 kB`
`react` Overlay	`38.784 kB` `13.401 kB`
`react` Panel	`194.946 kB` `58.34 kB`
`react` Persona	`111.705 kB` `35.58 kB`
`react` PersonaCoin	`111.705 kB` `35.58 kB`
`react` PersonaPresence	`55.928 kB` `18.715 kB`
`react` Pickers	`287.603 kB` `80.607 kB`
`react` Pivot	`184.252 kB` `55.823 kB`
`react` Popup	`12.032 kB` `4.114 kB`
`react` Positioning	`21.821 kB` `7.334 kB`
`react` PositioningContainer	`70.754 kB` `22.84 kB`
`react` ProgressIndicator	`37.498 kB` `12.906 kB`
`react` Rating	`78.989 kB` `25.18 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` ScrollablePane	`53.538 kB` `17.113 kB`
`react` SearchBox	`182.982 kB` `55.1 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`226.659 kB` `66.321 kB`
`react` Selection	`41.202 kB` `11.839 kB`
`react` Separator	`33.397 kB` `11.529 kB`
`react` Shimmer	`47.265 kB` `15.632 kB`
`react` ShimmeredDetailsList	`236.654 kB` `67.42 kB`
`react` Slider	`55.575 kB` `18.574 kB`
`react` SpinButton	`186.661 kB` `56.205 kB`
`react` Spinner	`39.691 kB` `13.815 kB`
`react` Stack	`40.761 kB` `13.931 kB`
`react` Sticky	`32.064 kB` `10.324 kB`
`react` Styling	`44.812 kB` `14.688 kB`
`react` SwatchColorPicker	`186.166 kB` `56.724 kB`
`react` TeachingBubble	`200.004 kB` `59.345 kB`
`react` Text	`35.931 kB` `12.486 kB`
`react` TextField	`78.587 kB` `24.642 kB`
`react` Theme	`42.456 kB` `13.773 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` TimePicker	`235.197 kB` `68.29 kB`
`react` Toggle	`44.17 kB` `15.346 kB`
`react` Tooltip	`84.225 kB` `27.277 kB`
`react` Utilities	`71.851 kB` `21.843 kB`
`react` Viewport	`22.945 kB` `7.292 kB`
`react` WeeklyDayPicker	`98.762 kB` `30.828 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-accordion` Accordion (including children components)	`100.12 kB` `30.422 kB`
`react-alert` Alert	`83.737 kB` `23.474 kB`
`react-avatar` Avatar	`50.175 kB` `15.944 kB`
`react-avatar` AvatarGroup	`19.704 kB` `7.796 kB`
`react-avatar` AvatarGroupItem	`64.831 kB` `20.274 kB`
`react-badge` Badge	`26.905 kB` `8.729 kB`
`react-badge` CounterBadge	`27.806 kB` `9.024 kB`
`react-badge` PresenceBadge	`25.311 kB` `9.306 kB`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`115.465 kB` `31.832 kB`
`react-button` Button	`39.513 kB` `11.169 kB`
`react-button` CompoundButton	`46.874 kB` `12.661 kB`
`react-button` MenuButton	`44.292 kB` `12.542 kB`
`react-button` SplitButton	`52.306 kB` `14.134 kB`
`react-button` ToggleButton	`56.559 kB` `13.068 kB`
`react-calendar-compat` Calendar Compat	`152.067 kB` `39.826 kB`
`react-card` Card - All	`101.55 kB` `28.92 kB`
`react-card` Card	`96.373 kB` `27.403 kB`
`react-card` CardFooter	`13.064 kB` `5.385 kB`
`react-card` CardHeader	`15.307 kB` `6.143 kB`
`react-card` CardPreview	`14.015 kB` `5.752 kB`
`react-checkbox` Checkbox	`35.65 kB` `12.076 kB`
`react-combobox` Combobox (including child components)	`102.176 kB` `32.976 kB`
`react-combobox` Dropdown (including child components)	`103.543 kB` `32.927 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`70.726 kB` `20.47 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`217.193 kB` `61.95 kB`
`react-components` react-components: FluentProvider & webLightTheme	`43.211 kB` `14.303 kB`
`react-datepicker-compat` DatePicker Compat	`224.513 kB` `62.955 kB`
`react-dialog` Dialog (including children components)	`100.923 kB` `29.928 kB`
`react-divider` Divider	`20.82 kB` `7.763 kB`
`react-field` Field	`22.544 kB` `8.61 kB`
`react-image` Image	`15.745 kB` `6.23 kB`
`react-infobutton` InfoButton	`138.69 kB` `43.394 kB`
`react-infobutton` InfoLabel	`142.491 kB` `44.625 kB`
`react-input` Input	`26.887 kB` `9.118 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.783 kB` `1.648 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.266 kB` `5.828 kB`
`react-link` Link	`17.082 kB` `6.911 kB`
`react-menu` Menu (including children components)	`149.422 kB` `45.506 kB`
`react-menu` Menu (including selectable components)	`152.108 kB` `46.016 kB`
`react-message-bar` MessageBar (all components)	`25.566 kB` `9.131 kB`
`react-northstar` Accordion	`85.357 kB` `26.509 kB`
`react-northstar` Alert	`87.425 kB` `26.91 kB`
`react-northstar` Animation	`55.304 kB` `17.834 kB`
`react-northstar` Attachment	`86.819 kB` `26.7 kB`
`react-northstar` Avatar	`80.254 kB` `24.634 kB`
`react-northstar` Box	`75.223 kB` `23.814 kB`
`react-northstar` Breadcrumb	`79.889 kB` `24.707 kB`
`react-northstar` Button	`83.135 kB` `25.957 kB`
`react-northstar` Card	`82.674 kB` `25.027 kB`
`react-northstar` Carousel	`105.15 kB` `31.882 kB`
`react-northstar` Chat	`152.326 kB` `45.963 kB`
`react-northstar` Checkbox	`79.782 kB` `25.085 kB`
`react-northstar` Datepicker	`184.887 kB` `56.167 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.564 kB` `12.07 kB`
`react-northstar` Dialog	`112.02 kB` `33.638 kB`
`react-northstar` Divider	`76.594 kB` `24.137 kB`
`react-northstar` Dropdown	`196.43 kB` `59.442 kB`
`react-northstar` Embed	`81.446 kB` `25.42 kB`
`react-northstar` Flex	`47.702 kB` `15.45 kB`
`react-northstar` Form	`92.492 kB` `28.881 kB`
`react-northstar` Grid	`70.555 kB` `22.283 kB`
`react-northstar` Header	`74.731 kB` `23.476 kB`
`react-northstar` Image	`73.566 kB` `23.339 kB`
`react-northstar` Input	`88.31 kB` `27.784 kB`
`react-northstar` ItemLayout	`78.206 kB` `24.458 kB`
`react-northstar` Label	`77.895 kB` `24.415 kB`
`react-northstar` Layout	`75.368 kB` `23.806 kB`
`react-northstar` List	`88.472 kB` `27.57 kB`
`react-northstar` Loader	`78.591 kB` `24.745 kB`
`react-northstar` Menu	`126.85 kB` `39.875 kB`
`react-northstar` MenuButton	`161.254 kB` `48.881 kB`
`react-northstar` Pill	`83.697 kB` `26.077 kB`
`react-northstar` Popup	`133.56 kB` `41.486 kB`
`react-northstar` Portal	`58.294 kB` `18.855 kB`
`react-northstar` Provider	`93.114 kB` `29.626 kB`
`react-northstar` RadioGroup	`83.25 kB` `26.056 kB`
`react-northstar` Reaction	`77.255 kB` `24.138 kB`
`react-northstar` Segment	`76.184 kB` `23.899 kB`
`react-northstar` Skeleton	`77.74 kB` `24.21 kB`
`react-northstar` Slider	`84.235 kB` `26.744 kB`
`react-northstar` SplitButton	`176.487 kB` `52.632 kB`
`react-northstar` Status	`76.247 kB` `24.059 kB`
`react-northstar` SvgIcon	`36.819 kB` `11.744 kB`
`react-northstar` Table	`80.765 kB` `25.159 kB`
`react-northstar` Text	`74.089 kB` `23.522 kB`
`react-northstar` TextArea	`74.223 kB` `23.501 kB`
`react-northstar` Toolbar	`173.3 kB` `52.087 kB`
`react-northstar` Tooltip	`108.23 kB` `34.491 kB`
`react-northstar` Tree	`87.83 kB` `27.223 kB`
`react-northstar` Video	`75.379 kB` `23.794 kB`
`react-overflow` hooks only	`12.862 kB` `4.827 kB`
`react-persona` Persona	`57.066 kB` `17.821 kB`
`react-popover` Popover	`126.88 kB` `39.806 kB`
`react-portal` Portal	`13.629 kB` `4.875 kB`
`react-portal-compat` PortalCompatProvider	`7.94 kB` `2.592 kB`
`react-positioning` usePositioning	`26.398 kB` `9.539 kB`
`react-progress` ProgressBar	`17.428 kB` `6.898 kB`
`react-provider` FluentProvider	`23.751 kB` `8.66 kB`
`react-radio` Radio	`32.946 kB` `10.252 kB`
`react-radio` RadioGroup	`15.354 kB` `6.265 kB`
`react-select` Select	`28.609 kB` `10.205 kB`
`react-slider` Slider	`39.943 kB` `12.969 kB`
`react-spinbutton` SpinButton	`36.774 kB` `11.788 kB`
`react-spinner` Spinner	`23.517 kB` `8.512 kB`
`react-switch` Switch	`35.134 kB` `11.198 kB`
`react-table` DataGrid	`165.162 kB` `45.897 kB`
`react-table` Table (Primitives only)	`45.318 kB` `14.117 kB`
`react-table` Table as DataGrid	`136.542 kB` `36.827 kB`
`react-table` Table (Selection only)	`76.307 kB` `20.546 kB`
`react-table` Table (Sort only)	`74.973 kB` `20.156 kB`
`react-tags` InteractionTag	`15.259 kB` `6.058 kB`
`react-tags` Tag	`29.982 kB` `9.439 kB`
`react-tags` TagGroup	`80.55 kB` `24.027 kB`
`react-text` Text - Default	`16.705 kB` `6.569 kB`
`react-text` Text - Wrappers	`19.878 kB` `6.896 kB`
`react-textarea` Textarea	`30.947 kB` `10.476 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.317 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.498 kB`
`react-timepicker-compat` TimePicker	`104.206 kB` `34.375 kB`
`react-toast` Toast (including Toaster)	`100.192 kB` `29.763 kB`
`react-tooltip` Tooltip	`54.576 kB` `19.192 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 94468f9267b77b44cbc9114c9eee6957496c2999}

fabricteam · 2023-05-25T14:24:43Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender-with-unmount	67	74	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	650	628	5000
Button	mount	315	311	5000
Field	mount	1105	1181	5000
FluentProvider	mount	685	693	5000
FluentProviderWithTheme	mount	75	87	10
FluentProviderWithTheme	virtual-rerender	63	59	10
FluentProviderWithTheme	virtual-rerender-with-unmount	67	74	10	Possible regression
MakeStyles	mount	859	858	50000
Persona	mount	1745	1726	5000
SpinButton	mount	1374	1449	5000

fabricteam · 2023-05-25T14:28:03Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
PortalMinimalPerf.default	90	84	1.07:1	analysis
RefMinimalPerf.default	118	114	1.04:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
IconMinimalPerf.default	398	359	1.11:1
ListMinimalPerf.default	326	301	1.08:1
EmbedMinimalPerf.default	1899	1800	1.06:1
GridMinimalPerf.default	196	185	1.06:1
RadioGroupMinimalPerf.default	267	251	1.06:1
AttachmentMinimalPerf.default	82	78	1.05:1
ChatMinimalPerf.default	446	425	1.05:1
FormMinimalPerf.default	222	211	1.05:1
LayoutMinimalPerf.default	204	195	1.05:1
TextAreaMinimalPerf.default	288	273	1.05:1
AttachmentSlotsPerf.default	646	621	1.04:1
BoxMinimalPerf.default	195	188	1.04:1
DropdownManyItemsPerf.default	403	386	1.04:1
ImageMinimalPerf.default	224	216	1.04:1
ItemLayoutMinimalPerf.default	701	675	1.04:1
TextMinimalPerf.default	199	192	1.04:1
CarouselMinimalPerf.default	262	254	1.03:1
ChatDuplicateMessagesPerf.default	152	148	1.03:1
HeaderSlotsPerf.default	464	450	1.03:1
ProviderMergeThemesPerf.default	650	632	1.03:1
ReactionMinimalPerf.default	215	208	1.03:1
VideoMinimalPerf.default	466	451	1.03:1
AvatarMinimalPerf.default	108	106	1.02:1
CheckboxMinimalPerf.default	1128	1110	1.02:1
DropdownMinimalPerf.default	1417	1392	1.02:1
HeaderMinimalPerf.default	214	210	1.02:1
ListCommonPerf.default	393	384	1.02:1
SegmentMinimalPerf.default	192	189	1.02:1
CustomToolbarPrototype.default	1473	1445	1.02:1
ButtonOverridesMissPerf.default	652	646	1.01:1
ListWith60ListItems.default	366	361	1.01:1
StatusMinimalPerf.default	380	378	1.01:1
ToolbarMinimalPerf.default	539	533	1.01:1
TooltipMinimalPerf.default	1258	1242	1.01:1
CardMinimalPerf.default	301	301	1:1
DividerMinimalPerf.default	205	204	1:1
InputMinimalPerf.default	528	529	1:1
LoaderMinimalPerf.default	183	183	1:1
MenuButtonMinimalPerf.default	933	937	1:1
ProviderMinimalPerf.default	199	199	1:1
SplitButtonMinimalPerf.default	2252	2252	1:1
TableManyItemsPerf.default	1094	1095	1:1
TreeMinimalPerf.default	487	489	1:1
AnimationMinimalPerf.default	293	297	0.99:1
DatepickerMinimalPerf.default	3508	3531	0.99:1
FlexMinimalPerf.default	152	153	0.99:1
LabelMinimalPerf.default	209	212	0.99:1
ListNestedPerf.default	326	329	0.99:1
RosterPerf.default	1574	1594	0.99:1
PopupMinimalPerf.default	345	347	0.99:1
SkeletonMinimalPerf.default	195	196	0.99:1
AccordionMinimalPerf.default	87	89	0.98:1
AlertMinimalPerf.default	157	161	0.98:1
ButtonMinimalPerf.default	83	85	0.98:1
DialogMinimalPerf.default	429	436	0.98:1
MenuMinimalPerf.default	493	505	0.98:1
SliderMinimalPerf.default	738	752	0.98:1
TreeWith60ListItems.default	80	82	0.98:1
TableMinimalPerf.default	231	238	0.97:1
ChatWithPopoverPerf.default	182	191	0.95:1
ButtonSlotsPerf.default	305	329	0.93:1

size-auditor · 2023-05-25T14:31:34Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8a4890f9c1dd5e7c1ed152d5b177fc59ea67405c (build)

codesandbox-ci · 2023-05-25T14:33:41Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam · 2023-05-25T14:37:32Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	632	651	5000
Breadcrumb	mount	1734	1666	1000
Checkbox	mount	1701	1710	5000
CheckboxBase	mount	1518	1466	5000
ChoiceGroup	mount	2988	2999	5000
ComboBox	mount	662	649	1000
CommandBar	mount	6473	6508	1000
ContextualMenu	mount	15506	15781	1000
DefaultButton	mount	749	771	5000
DetailsRow	mount	2192	2196	5000
DetailsRowFast	mount	2178	2141	5000
DetailsRowNoStyles	mount	1991	1996	5000
Dialog	mount	2811	2857	1000
DocumentCardTitle	mount	225	234	1000
Dropdown	mount	1978	1968	5000
FocusTrapZone	mount	1143	1120	5000
FocusZone	mount	1086	1075	5000
GroupedList	mount	42299	42543	2
GroupedList	virtual-rerender	20160	20438	2
GroupedList	virtual-rerender-with-unmount	51444	51990	2
GroupedListV2	mount	227	242	2
GroupedListV2	virtual-rerender	211	214	2
GroupedListV2	virtual-rerender-with-unmount	235	240	2
IconButton	mount	1084	1081	5000
Label	mount	345	351	5000
Layer	mount	2757	2740	5000
Link	mount	392	392	5000
MenuButton	mount	932	931	5000
MessageBar	mount	21454	21493	5000
Nav	mount	1952	1933	1000
OverflowSet	mount	794	784	5000
Panel	mount	1796	1824	1000
Persona	mount	764	758	1000
Pivot	mount	889	883	1000
PrimaryButton	mount	864	855	5000
Rating	mount	4658	4531	5000
SearchBox	mount	903	925	5000
Shimmer	mount	1867	1876	5000
Slider	mount	1340	1317	5000
SpinButton	mount	2874	3013	5000
Spinner	mount	384	394	5000
SplitButton	mount	1827	1784	5000
Stack	mount	413	399	5000
StackWithIntrinsicChildren	mount	835	854	5000
StackWithTextChildren	mount	2639	2644	5000
SwatchColorPicker	mount	6272	6107	5000
TagPicker	mount	1437	1467	5000
Text	mount	391	359	5000
TextField	mount	937	902	5000
ThemeProvider	mount	841	845	5000
ThemeProvider	virtual-rerender	595	576	5000
ThemeProvider	virtual-rerender-with-unmount	1267	1271	5000
Toggle	mount	608	595	5000
buttonNative	mount	194	195	5000

fabricteam · 2023-05-25T14:41:57Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-05-25T14:42:38Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-05-25T14:58:21Z

🕵 fluentuiv8 No visual regressions between this PR and main

…mponents if any v9 package is affected

…check task

…n use cache and /unstable apis work

…rts package that is not a dep nor v9 suite dep

…o be build instead hardcoding strings

…ck hack

fabricteam · 2024-02-19T17:01:06Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-02-19T17:06:24Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2024-02-21T10:07:39Z

.devops/templates/build-test-lint.yml

@@ -6,43 +6,58 @@ steps:
      filePath: yarn-ci.sh


🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

Pivot - Overflow 2 screenshots

Image Name Diff(in Pixels) Image Type

Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png 0 Added

Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png 0 Added

layershifter · 2024-08-13T14:12:16Z

Closing for housekeeping 🏡 Feel free to re-open 👍

msft-fluent-ui-bot assigned layershifter May 25, 2023

github-actions bot added this to the May Project Cycle Q2 2023 milestone May 25, 2023

Hotell changed the title ~~Hotell/build/faster ci/type check temporary boost hack~~ ci: improve type-checking speed by ~60% with temporary hack May 25, 2023

Hotell mentioned this pull request May 25, 2023

Epic: road to faster CI/CD #27359

Open

9 tasks

Hotell changed the title ~~ci: improve type-checking speed by ~60% with temporary hack~~ ci: improve v9 type-checking speed by ~60% with temporary hack May 25, 2023

Hotell changed the title ~~ci: improve v9 type-checking speed by ~60% with temporary hack~~ ci: improve v9 type-checking speed by ~80% with temporary hack May 26, 2023

Hotell force-pushed the hotell/build/faster-ci/type-check-temporary-boost-hack branch from 9c75bb0 to 16968e2 Compare May 29, 2023 10:41

Hotell unassigned layershifter Feb 9, 2024

Hotell added 12 commits February 19, 2024 17:20

feat(scripts-executors): add utility to run generate-api for react-co…

62f20a2

…mponents if any v9 package is affected

perf: use type-check task to improve type-checking speeds up to 60%

10013c7

generate changefiles

647460e

feat(tools): update migrate-converged-pkg generator to set just type-…

bd2e132

…check task

ci: add generate-api task dependency to lage

2d9e57e

feat(scripts-executors): use build instead of generate-api so lage ca…

8a498f0

…n use cache and /unstable apis work

fix(react-dialog): remove circular dependency from /testing

48d805d

feat(scripts-executors): handle special cases where v9 pkg story impo…

3e3121e

…rts package that is not a dep nor v9 suite dep

feat(scripts-executors): use nx-graph to resolve packages that need t…

3581433

…o be build instead hardcoding strings

refactor(scripts-executors): polish type-check ci hack implementation

041e50a

ci: move hack to new pipeline definition after rebase

3c16c43

generate change files after rebase

a5cdb6a

Hotell force-pushed the hotell/build/faster-ci/type-check-temporary-boost-hack branch from 16968e2 to a5cdb6a Compare February 19, 2024 16:30

github-actions bot modified the milestones: May Project Cycle Q2 2023, February Project Cycle Q1 2024 Feb 19, 2024

chore: update types and imports after nx 17 migration within type che…

781bd76

…ck hack

Hotell mentioned this pull request Feb 20, 2024

ci: improve v9 type-checking speed by ~80% with imperative ghost dependencies type generation #30577

Closed

Hotell changed the title ~~ci: improve v9 type-checking speed by ~80% with temporary hack~~ ci: improve v9 type-checking speed by ~80% with mamual ghost dependencies build on CI Feb 21, 2024

ci: scope test to only react-text

90fa524

Hotell changed the title ~~ci: improve v9 type-checking speed by ~80% with mamual ghost dependencies build on CI~~ ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI Feb 21, 2024

fabricteam reviewed Feb 21, 2024

View reviewed changes

layershifter closed this Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

Hotell commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

size-auditor bot commented May 25, 2023 •

edited

Loading

codesandbox-ci bot commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented Feb 19, 2024 •

edited

Loading

fabricteam commented Feb 19, 2024 •

edited

Loading

fabricteam Feb 21, 2024

layershifter commented Aug 13, 2024

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png	0	Added
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png	0	Added

ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

Conversation

Hotell commented May 25, 2023 • edited Loading

Previous Behavior

New Behavior

Scoped time comparison

Related Issue(s)

fabricteam commented May 25, 2023 • edited Loading

📊 Bundle size report

fabricteam commented May 25, 2023 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented May 25, 2023 • edited Loading

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

size-auditor bot commented May 25, 2023 • edited Loading

Asset size changes

codesandbox-ci bot commented May 25, 2023 • edited Loading

fabricteam commented May 25, 2023 • edited Loading

Perf Analysis (@fluentui/react)

fabricteam commented May 25, 2023 • edited Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam commented May 25, 2023 • edited Loading

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented May 25, 2023 • edited Loading

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam commented Feb 19, 2024 • edited Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented Feb 19, 2024 • edited Loading

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam Feb 21, 2024

Choose a reason for hiding this comment

🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

layershifter commented Aug 13, 2024

Hotell commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 25, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

size-auditor bot commented May 25, 2023 •

edited

Loading

codesandbox-ci bot commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented May 25, 2023 •

edited

Loading

fabricteam commented Feb 19, 2024 •

edited

Loading

fabricteam commented Feb 19, 2024 •

edited

Loading